[feature] Sync rule dependencies UI changes#1022
Draft
MatiasArriola wants to merge 3 commits intodevelopmentfrom
Draft
[feature] Sync rule dependencies UI changes#1022MatiasArriola wants to merge 3 commits intodevelopmentfrom
MatiasArriola wants to merge 3 commits intodevelopmentfrom
Conversation
…ector title - Add toggles before showing the dependencies dropdowns, based on defaults - Extract SynchronizationRule syncParamsDefaults for this purpose, and a useConfigureDependencies hook to handle toggles state and logic. - Change titles for MultiSelectors, and align titles to each Select box
refactor was needed to include a single changeObjectsAndReferences callback instead of multiple separate calls, to avoid race conditions when updating one prop after another.
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
TODO: confirm the removal of "Remove lastUpdated, lastUpdatedBy, created and createdBys". Also confirm if needed the remove the feature entirely and not just the UI.
📹 Screenshots/Screen capture
mdsync-dependencies-options.webm